Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpc skip falsy contract #984

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Rpc skip falsy contract #984

merged 2 commits into from
Feb 9, 2024

Conversation

cabrador
Copy link
Collaborator

@cabrador cabrador commented Feb 9, 2024

Description

This PR skips validation for falsy contract 0xe0c38b2a8d09aad53f1c67734b9a95e43d5981c0 further investigation needs to be made. #983

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@cabrador cabrador marked this pull request as ready for review February 9, 2024 05:56
wsodsong
wsodsong approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@wsodsong wsodsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this workaround!

rpc/execute.go Show resolved Hide resolved
@cabrador cabrador merged commit e9ef0b1 into develop Feb 9, 2024
1 check passed
@wsodsong wsodsong mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsodsong wsodsong wsodsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabrador @wsodsong