-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Working Clock Components #21
base: master
Are you sure you want to change the base?
Conversation
A simple analog clock with hour, minute, and second hands animated in CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greate work from you.
The overall component looks really appealing and good.
Maby it would be a good idea to set the starting time to "10:10:00" as it's used by clock brands for marketing (only if you want).
I have added some things you have to adjust and please add a description to your pull request.
@@ -1,25 +1,25 @@ | |||
export enum EArtworkTags { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not formate files you didn't edit anything
tags: [EArtworkTags.COMPLEX, "TIME"], | ||
backgroundColor: "#ffffff", | ||
full: false, | ||
oneLink: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont have to add an extra link to you github, use this for other links of remove it because the link to you github is automatically generated out of your name.
description: | ||
"A simple analog clock with hour, minute, and second hands animated in CSS.", | ||
gitHubName: "duyb2111918", | ||
tags: [EArtworkTags.COMPLEX, "TIME"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add the tag animation and please only use tags inside EArtworkTags because it won't be possible to find it with tags if you make your own, also if you want to be able to find you component if you type "time" its better to add time to the title or the description.
titel: string; | ||
description: string; | ||
gitHubName: string; | ||
tags?: EArtworkTags[] | string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the ";"
@@ -1,39 +1,55 @@ | |||
import {ReactNode} from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also remove your formating from this file to keep it consistent.
@duyb2111918 I have now added eslint and prettier to the project please also try configure them inside your VS-Code/InteliJ so we can keep the project clean. ps. |
Description
Please include a summary of the changes and reference the issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Used issue #16
Type of change
Checklist:
CODE OF CONDUCT
& theCONTRIBUTING
.Components specific
Feature specific