Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Working Clock Components #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

duyb2111918
Copy link

@duyb2111918 duyb2111918 commented Nov 4, 2024

Description

Please include a summary of the changes and reference the issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Used issue #16

Type of change

  • New Component (non-breaking change which adds functionality to the website)
  • New Feature (non-breaking change which adds a new css component)
  • Bug fix (non-breaking change which fixes an bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project.
  • I have updated my code state to the newest version.
  • I have performed a self-review of my code.
  • My code is properly structured and easy to read for others.
  • If something could be unclear/complex for others to understand I have made a comment for this part.
  • My changes generate no new warnings or errors inside the console.
  • Its easy to see what issue was used for this changes.
  • I have only used module css classes, with exeption for some part where you can use the index.scss.
  • I have read the CODE OF CONDUCT & the CONTRIBUTING.

Components specific

  • The Component is somewhere unique to already other created components.
  • I have only used html and css to create my component, apart from the react component.
  • I have made the whole component myself and didn't stole it from someone other.
  • I have documented my own copyright statments inside the artworklist.

Feature specific

  • My new Feature does not effect the styling and the functioning of other thing, in a way so they don't work anymore.
  • If I edited some core files of the project I have checked the code extra carfully.
  • If the new feature have UI changes, I have made them responsive as good as possible.

A simple analog clock with hour, minute, and second hands animated in CSS.
Copy link
Owner

@FabDonRixos FabDonRixos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greate work from you.
The overall component looks really appealing and good.

Maby it would be a good idea to set the starting time to "10:10:00" as it's used by clock brands for marketing (only if you want).

I have added some things you have to adjust and please add a description to your pull request.

.hintrc Show resolved Hide resolved
@@ -1,25 +1,25 @@
export enum EArtworkTags {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not formate files you didn't edit anything

tags: [EArtworkTags.COMPLEX, "TIME"],
backgroundColor: "#ffffff",
full: false,
oneLink: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont have to add an extra link to you github, use this for other links of remove it because the link to you github is automatically generated out of your name.

description:
"A simple analog clock with hour, minute, and second hands animated in CSS.",
gitHubName: "duyb2111918",
tags: [EArtworkTags.COMPLEX, "TIME"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the tag animation and please only use tags inside EArtworkTags because it won't be possible to find it with tags if you make your own, also if you want to be able to find you component if you type "time" its better to add time to the title or the description.

titel: string;
description: string;
gitHubName: string;
tags?: EArtworkTags[] | string[];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the ";"

@@ -1,39 +1,55 @@
import {ReactNode} from "react";
Copy link
Owner

@FabDonRixos FabDonRixos Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove your formating from this file to keep it consistent.

@FabDonRixos
Copy link
Owner

FabDonRixos commented Nov 7, 2024

@duyb2111918 I have now added eslint and prettier to the project please also try configure them inside your VS-Code/InteliJ so we can keep the project clean.
If something doesn't work please contact me.

ps.
The manual on what to configure is listed inside the ReadMe.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants