zebra: fix wrong linkdown flag

[anlancs]

Add this one line command to one down interface (mask is 192.168.0.0/24):

ip link set dev enp2s0 up;ip route add 3.3.3.3/32 via 192.168.0.1 dev enp2s0 proto kernel onlink

Before:

K>* 3.3.3.3/32 [0/0] via 192.168.0.1, enp2s0 onlink linkdown, weight 1, 00:00:02

After:

K>* 3.3.3.3/32 [0/0] via 192.168.0.1, enp2s0 onlink, weight 1, 00:00:02

It's only display problem, just correct this linkdown flag.

[ton31337]

@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

[mergify]

backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

🟠 Waiting for conditions to match

• merged [📌 backport requirement]

[donaldsharp]

Why is this not being set on link up?

[anlancs]

Why is this not being set on link up?

It is the time issue. If with two commands in two lines, there is no this issue. Now they are combined into one line, so the UP message of netlink comes later. @donaldsharp

[donaldsharp]

I am not seeing this problem:

sharpd@eva ~/f/t/t/bgp_bmp (master)> sudo vtysh -c "show ip route kernel"
Codes: K - kernel route, C - connected, L - local, S - static,
       R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric, t - Table-Direct,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

K>* 0.0.0.0/0 [0/100] via 192.168.119.1, enp13s0, weight 1, 03:34:37
K>* 169.254.0.0/16 [0/1000] is directly connected, virbr2 linkdown, weight 1, 04:22:24
sharpd@eva ~/f/t/t/bgp_bmp (master)> sudo ip link set dev dummy1 up; sudo ip route add 3.3.3.3/32 via 192.168.0.1 dev dummy1 proto kernel onlink
sharpd@eva ~/f/t/t/bgp_bmp (master)> sudo vtysh -c "show ip route kernel"
Codes: K - kernel route, C - connected, L - local, S - static,
       R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric, t - Table-Direct,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

K>* 0.0.0.0/0 [0/100] via 192.168.119.1, enp13s0, weight 1, 03:34:48
K>* 3.3.3.3/32 [0/0] via 192.168.0.1, dummy1 onlink, weight 1, 00:00:02
K>* 169.254.0.0/16 [0/1000] is directly connected, virbr2 linkdown, weight 1, 04:22:35
sharpd@eva ~/f/t/t/bgp_bmp (master)> 

How exactly do you reproduce?

[anlancs]

@donaldsharp Use the REAL interface, try your enp13s0?

[donaldsharp]

if the up comes later we should scan the kernel routes and set the flag there. Hence this is the wrong spot to do the work.

[anlancs]

imo just check this UP interface at this spot is enough, can't find a better spot… @donaldsharp