Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary link-time dependence on xproto. #167

Conversation

greenc-FNAL
Copy link
Member

This partially reverts commit 7a3f7d0.

Copy link

@marcmengel marcmengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do this, but we do need xproto to build, so we really should make it
depends_on("xproto", type="build", when="+x")
and not just drop it (?),. I'll let you decide which you prefer.

@greenc-FNAL
Copy link
Member Author

We could do this, but we do need xproto to build, so we really should make it depends_on("xproto", type="build", when="+x") and not just drop it (?),. I'll let you decide which you prefer.

You mean like this?
https://github.com/FNALssi/spack/pull/167/files#diff-3647c57590fe54f56f65c1ca0b69dd8a935fafe9420c91038355ddecd8b170fdR236

Copy link

@marcmengel marcmengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@marcmengel marcmengel merged commit f358285 into FNALssi:fnal-develop Aug 24, 2023
10 checks passed
@greenc-FNAL greenc-FNAL deleted the maintenance/remove-unnecessary-root-dep branch August 30, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants