Stash session and credentials during copilot access #52980
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This will allow us to remove the code removed in https://github.com/Expensify/Web-Expensify/pull/44547, but should not yet require that change. However, please test with and without that backend change locally (I did too but just to be safe)
Fixed Issues
$ #51042
PROPOSAL:
Tests
Internally - please do the following
Update your authtokens to expire after a short period (e.g. 20 seconds) here - I don't remember which one of these is the one that matters so you can update both to be safe
As noted above please double check this works with and without https://github.com/Expensify/Web-Expensify/pull/44547.
This can also be tested on Hybrid App with https://github.com/Expensify/Mobile-Expensify/pull/13289 - you don't need to do that here I don't think, but calling out that I did do that :)
Create an account, verify it (log out and back in again) and add a copilot
Log in as that copilot
Copilot into the original account
Verify that everything seems to work fine (requests go through, etc.)
Switch back to the copilot's original account
Verify that everything seems to work fine (requests go through, etc.)
Wait 20 seconds (or however long you set your authtokens to expire)
Do some more actions, and check for the Authenticate call to go through successfully.
Verify that everything seems to work fine
Repeat steps 3-9 (just to make sure that nothing goes weird with the copilot tokens).
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
2024-11-25_14-56-20.mp4
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop