Migrate E/App to use `PlatformStackNavigation` #49937

chrispader · 2024-09-30T14:32:08Z

@mountiny @ishpaul777 @chiragsalian

Details

This PR migrates the App to use PlatformStackNavigation types and navigator components implemented in #37891

Fixed Issues

$ #37891
PROPOSAL: #37891 (comment)

Tests

Open app
press on search filed
be sure that:
- screen transition is from left to right (Android/iOS/mWeb)
- drawer tranistion is from left to right + content behind drawer is still visible (web)
- screen search can be loaded (i. e. it's not infinite loading) -> [HOLD for payment 2024-03-07] [Android] infinite loading search screen #37156
close screen
- on iOS test that it can be dismissed via gesture from right to left [HOLD for payment 2024-03-14] Gesture to hide the search page should be right to left #37354 and back button
- on mWeb iOS it can be dismissed via gesture from left to right and back button
- on Android can be closed via system gestures and back button
- on web can be closed via back button
open any chat
tap on composer
go to previous screen
- on iOS/mWeb iOS do it via gesture from left to right and back button
- on Android/web do it via back button
be sure there is no keyboard jumps on previous screen -> [HOLD for payment 2024-10-17] [HOLD for payment 2024-06-06] [HOLD #37891] Keyboard jumps around when swiping back from chat to LHN with gesture #37923
open chat again
tap on task
tap on Assignee
be sure there is no infinite loading for the screen -> [HOLD for payment 2024-03-07] Android - Task-Tapping assignee shows infinite loading page #37252
go back to task
tap on Title
be sure keyboard is opened automatically -> [HOLD for payment 2024-03-07] [$500] Android - Task - Keyboard does not open after selecting task title #37273
go back to main page
tap on user avatar (to open Account settings)
tap on wallet, tap on "Add bank account"
tap on "Debit card"
be sure keyboard gets opened automatically -> [HOLD for payment 2024-03-07] [$500] Android - Wallet - The keyboard does not open automatically when the debit card is opened #37325
go back to main page
press "+" in TabBar
tap Request Money
enter any amount
press "Next"
be sure that on participant screen keyboard appears from the bottom -> [HOLD for payment 2024-03-07] [$500] IOU - Keyboard comes out from right to left on participant screen #37257
Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.Nov.26.2024.Expensify.Dev.mp4

Android: mWeb Chrome

android.web.webm

iOS: Native

ScreenRecording_11-26-2024.15-56-14_1.MP4

iOS: mWeb Safari

Running mWeb in iOS simulator is currently not possible due to this issue:

MacOS: Chrome / Safari

Screen.Recording.2024-11-26.at.15.32.29.mov

MacOS: Desktop

Screen.Recording.2024-11-26.at.15.43.23.mov

melvin-bot · 2024-09-30T14:32:42Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2024-09-30T16:50:25Z

Re-assigning to @chiragsalian and @mountiny for review since it looks like they have more context.

chrispader · 2024-10-01T13:08:10Z

@mountiny or @chiragsalian please from now on create ad-hoc builds from here. I fixed all remaining reported errors yesterday, so we can probably trigger a new build already.

chrispader · 2024-10-01T16:56:46Z

The ad-hoc iOS build fail is also going to be related to the patch from #49936

ishpaul777 · 2024-10-03T11:05:15Z

@mountiny Please run adhoc builds here when you have a moment, i plan to work on testing this fully today

mountiny · 2024-10-03T23:10:53Z

Running

github-actions · 2024-10-03T23:44:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://49937.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

chrispader · 2024-10-04T08:55:47Z

@mountiny Please run adhoc builds here when you have a moment, i plan to work on testing this fully today

The PR didn't have the changes to the react-native-vision-camera patches up until now. Please trigger another set of ad-hoc builds :)

mountiny · 2024-10-04T11:46:12Z

https://github.com/Expensify/App/actions/runs/11179336829

github-actions · 2024-10-04T12:29:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-10-04T12:50:24Z

Bug on the workspace page

mountiny · 2024-10-04T12:52:06Z

@chrispader Looking great! I think there are two things I have noticed:

There is a noticeable delay of idk 0.5s after clicking on the chat row for the animation to start
The chat finder modal is opening from the bottom, we want to keep the same animation we have now in main - animating from left

ishpaul777 · 2024-10-04T17:46:26Z

package-lock.json

commenting so this shows on my k2 for easy access

chrispader · 2024-10-06T18:10:57Z

Bug on the workspace page

@chrispader Looking great! I think there are two things I have noticed:

There is a noticeable delay of idk 0.5s after clicking on the chat row for the animation to start

The chat finder modal is opening from the bottom, we want to keep the same animation we have now in main - animating from left

@mountiny Both bugs are fixed!

I couldn't really see a difference between Stack navigator and Native-Stack while testing in this PR: (you meant when clicking on an item in the Sidebar right?)

Stack

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-06.at.17.38.30.mp4

Native Stack

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-06.at.20.09.51.mp4

chrispader · 2024-10-06T18:12:27Z

I will be OOO the next week, but i will hand this over to one of our other Margelo engineers. If there are any urgent issues i can also help with that, but i'm not gonna be on my Macbook unfortunately

ishpaul777 · 2024-10-06T18:19:38Z

I am now available for around ~2 hours i'll pull and start testing this locally

ishpaul777 · 2024-11-25T20:27:28Z

On it 👀

ishpaul777 · 2024-11-25T20:41:24Z

@mountiny @chrispader Issue is fixed 🎉

mountiny · 2024-11-25T20:44:34Z

yay

chrispader · 2024-11-25T22:52:58Z

I just fixed the last issue #49937 (comment)

@ishpaul777 please confirm that you're also not experiencing this anymore on web.

@mountiny if @ishpaul777 can confirm that this is fixed, i think we're ready to go for final review and merge! 🚀

github-actions · 2024-11-26T00:09:49Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-26T00:35:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-11-26T12:47:51Z

@ishpaul777 please confirm that you're also not experiencing this anymore on web.

its Fixed 🎉

ishpaul777 · 2024-11-26T12:57:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

WhatsApp.Video.2024-11-26.at.19.41.49.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-26.at.6.57.27.PM.mov

iOS: Native

trim.BC61141C-924D-481E-BC03-7F725DA08347.MOV

iOS: mWeb Safari

trim.63D7EE78-7F4B-42CD-B132-BDF15FB4ABAB.MOV

MacOS: Chrome / Safari

Screen.Recording.2024-11-26.at.7.12.31.PM-1.mov

MacOS: Desktop

Screen.Recording.2024-11-26.at.7.31.46.PM.mov

melvin-bot · 2024-11-26T14:14:00Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #53130.

ishpaul777 · 2024-11-26T14:17:12Z

@chrispader Will you add demo videos in checklist

chrispader · 2024-11-26T14:17:54Z

@chrispader Will you add demo videos in checklist

will do in a sec

chrispader · 2024-11-26T16:08:58Z

@chrispader Will you add demo videos in checklist

@ishpaul777 @mountiny just added screen recordings for all platforms, covering most navigation flows 👍

mountiny · 2024-11-26T17:22:54Z

Love it, thanks! We just did a new deploy with the edge-to-edge changes included, I would look into mergring this only once we confirm the next deploy is going fine

…-app

github-actions · 2024-11-28T11:43:09Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-28T12:08:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

c3024

Android: Native

stackAndroid-compressed.mp4

Android: mWeb Chrome

stackAndroidmWeb-compressed.mp4

iOS: Native

stackiOS-compressed.mp4

iOS: mWeb Safari

stackiOSmWeb1-compressed.mp4

stackiOSmWeb2.mp4

MacOS: Chrome / Safari

stackChrome.mp4

MacOS: Desktop

stackDesktop1.mp4

stackDesktop2.mp4

melvin-bot · 2024-11-28T17:15:27Z

🎯 @c3024, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #53264.

chrispader requested a review from a team as a code owner September 30, 2024 14:32

melvin-bot bot requested review from srikarparsi and removed request for a team September 30, 2024 14:32

chrispader changed the title ~~[WIP] Use PlatformStackNavigation in E/App (introduce native-stack navigation on native)~~ [WIP] Use PlatformStackNavigation in E/App (introduce native-stack navigation on mobile) Sep 30, 2024

chrispader changed the title ~~[WIP] Use PlatformStackNavigation in E/App (introduce native-stack navigation on mobile)~~ [WIP] Migrate E/App to use PlatformStackNavigation Sep 30, 2024

kirillzyusko mentioned this pull request Sep 30, 2024

[NoQA] Perf: PlatormStackNavigation - Use @react-navigation/native-stack on mobile platforms #37891

Merged

48 tasks

chrispader changed the title ~~[WIP] Migrate E/App to use PlatformStackNavigation~~ [HOLD on #37891] Migrate E/App to use PlatformStackNavigation Sep 30, 2024

chrispader force-pushed the @chrispader/use-platform-stack-navigation-in-app branch from 3b921d3 to 5701c46 Compare September 30, 2024 16:30

srikarparsi requested review from chiragsalian and mountiny and removed request for srikarparsi September 30, 2024 16:50

mountiny assigned chrispader Oct 1, 2024

mountiny added the Ready To Build label Oct 1, 2024

This comment has been minimized.

Sign in to view

ishpaul777 reviewed Oct 4, 2024

View reviewed changes

package-lock.json Outdated

Copy link

Contributor

ishpaul777 Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting so this shows on my k2 for easy access

chrispader added 6 commits November 25, 2024 22:50

move syncBrowserHistory files

a5924af

revert change

a60349c

fix: imports

f7f2557

fix: type CentralPaneScreenOptions in AuthScreens

1e36efe

fix: initial report not loading on login

c031e8f

fix: simplify code

3ee8c25

ishpaul777 approved these changes Nov 26, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Nov 26, 2024

Payment issue for E/App PR#49937 #53130

Closed

chore: update pods

4832dfe

kirillzyusko added 3 commits November 28, 2024 12:33

Merge branch 'main' into @chrispader/use-platform-stack-navigation-in…

b94528e

…-app

Merge branch 'main' into @chrispader/use-platform-stack-navigation-in…

fe01894

…-app

fix: StackScreenProps -> PlatformStackScreenProps

e19f126

c3024 approved these changes Nov 28, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Nov 28, 2024

Payment issue for E/App PR#49937 #53264

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate E/App to use `PlatformStackNavigation` #49937

Migrate E/App to use `PlatformStackNavigation` #49937

chrispader commented Sep 30, 2024 •

edited

Loading

melvin-bot bot commented Sep 30, 2024

srikarparsi commented Sep 30, 2024

chrispader commented Oct 1, 2024

This comment has been minimized.

chrispader commented Oct 1, 2024

ishpaul777 commented Oct 3, 2024

mountiny commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

chrispader commented Oct 4, 2024

mountiny commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

mountiny commented Oct 4, 2024

mountiny commented Oct 4, 2024 •

edited

Loading

ishpaul777 Oct 4, 2024

chrispader commented Oct 6, 2024 •

edited

Loading

chrispader commented Oct 6, 2024

ishpaul777 commented Oct 6, 2024 •

edited

Loading

ishpaul777 commented Nov 25, 2024

ishpaul777 commented Nov 25, 2024

mountiny commented Nov 25, 2024

chrispader commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

ishpaul777 commented Nov 26, 2024

ishpaul777 commented Nov 26, 2024 •

edited

Loading

melvin-bot bot commented Nov 26, 2024

ishpaul777 commented Nov 26, 2024

chrispader commented Nov 26, 2024

chrispader commented Nov 26, 2024

mountiny commented Nov 26, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

c3024 left a comment

melvin-bot bot commented Nov 28, 2024

Migrate E/App to use PlatformStackNavigation #49937

Are you sure you want to change the base?

Migrate E/App to use PlatformStackNavigation #49937

Conversation

chrispader commented Sep 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 30, 2024

srikarparsi commented Sep 30, 2024

chrispader commented Oct 1, 2024

This comment has been minimized.

chrispader commented Oct 1, 2024

ishpaul777 commented Oct 3, 2024

mountiny commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

chrispader commented Oct 4, 2024

mountiny commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

mountiny commented Oct 4, 2024

mountiny commented Oct 4, 2024 • edited Loading

ishpaul777 Oct 4, 2024

Choose a reason for hiding this comment

chrispader commented Oct 6, 2024 • edited Loading

Stack

Native Stack

chrispader commented Oct 6, 2024

ishpaul777 commented Oct 6, 2024 • edited Loading

ishpaul777 commented Nov 25, 2024

ishpaul777 commented Nov 25, 2024

mountiny commented Nov 25, 2024

chrispader commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

ishpaul777 commented Nov 26, 2024

ishpaul777 commented Nov 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 26, 2024

ishpaul777 commented Nov 26, 2024

chrispader commented Nov 26, 2024

chrispader commented Nov 26, 2024

mountiny commented Nov 26, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

c3024 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 28, 2024

Migrate E/App to use `PlatformStackNavigation` #49937

Migrate E/App to use `PlatformStackNavigation` #49937

chrispader commented Sep 30, 2024 •

edited

Loading

mountiny commented Oct 4, 2024 •

edited

Loading

chrispader commented Oct 6, 2024 •

edited

Loading

ishpaul777 commented Oct 6, 2024 •

edited

Loading

ishpaul777 commented Nov 26, 2024 •

edited

Loading