Merge pull request #1932 from Expensify/Rory-SkipStagingDeploysForRel…

…easeCreated Skip mobile staging deploys for production releases
Expensify · Mar 19, 2021 · 65f8720 · 65f8720
2 parents 8f8dbf6 + c865c83
commit 65f8720
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -13,9 +13,7 @@ jobs:
         if: github.actor == 'OSBotify'
         runs-on: ubuntu-latest
         env:
-#          TODO: Uncomment when we'd like to deploy to production
-#          SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
-          SHOULD_DEPLOY_PRODUCTION: ${{ false }}
+          SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
         steps:
             - uses: actions/checkout@v2
 
@@ -47,10 +45,13 @@ jobs:
                   LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}
 
             - name: Run Fastlane beta
+              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }}
               run: bundle exec fastlane android beta
 
+            # TODO: uncomment when we want to release iOS to production
             - name: Run Fastlane production
-              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
+#              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
+              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' && 'false' == 'true' }}
               run: bundle exec fastlane android production
               env:
                 VERSION: ${{ env.VERSION }}

diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml
@@ -16,9 +16,7 @@ jobs:
         if: github.actor == 'OSBotify'
         runs-on: macos-latest
         env:
-#          TODO: Uncomment when we'd like to deploy to production7
-#          SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
-          SHOULD_DEPLOY_PRODUCTION: ${{ false }}
+          SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
         steps:
             - uses: actions/checkout@v2
 
@@ -63,15 +61,18 @@ jobs:
                 LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}
 
             - name: Run Fastlane
+              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }}
               run: bundle exec fastlane ios beta
               env:
                   APPLE_CONTACT_EMAIL: ${{ secrets.APPLE_CONTACT_EMAIL }}
                   APPLE_CONTACT_PHONE: ${{ secrets.APPLE_CONTACT_PHONE }}
                   APPLE_DEMO_EMAIL: ${{ secrets.APPLE_DEMO_EMAIL }}
                   APPLE_DEMO_PASSWORD: ${{ secrets.APPLE_DEMO_PASSWORD }}
 
+            # TODO: uncomment when we want to release iOS to production
             - name: Run Fastlane for App Store release
-              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
+#              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
+              if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' && 'false' == 'true' }}
               run: bundle exec fastlane ios production
               env:
                 VERSION: ${{ env.NEW_IOS_VERSION }}