forked from Exiled-Official/EXILED
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXILED::Events] BeingObserved event stolen #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! This PR will require me to test it, since before it was having major test failures before, it that shouldn't take long 👍 |
Jesus-QC
added
the
Requires Testing
Things need to be verified by an Exiled Developer/Contributor
label
Sep 23, 2024
iamalexrouse
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
I have tested this PR and everything works as expected.
Misfiy
removed
the
Requires Testing
Things need to be verified by an Exiled Developer/Contributor
label
Sep 24, 2024
louis1706
approved these changes
Oct 19, 2024
VALERA771
approved these changes
Nov 7, 2024
louis1706
added a commit
to louis1706/EXILED
that referenced
this pull request
Nov 17, 2024
This reverts commit cc7c183.
louis1706
added a commit
that referenced
this pull request
Nov 17, 2024
* `[Exiled::Events]` `[Exiled::API]` New event + new property (#31) * new ev + previous role * suggestions * uwu * suj * fix * uwu --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> * [EXILED::Events] BeingObserved event stolen (#91) * Scp173 Observing, Stolen from https://github.com/ExMod-Team/EXILED/pull/72/files * Remove old comment * Fix Error Co-Authored-By: SrLicht <cerberus.tk.sl@gmail.com> * NW Documentation * moving forward * YES * Fix * Update * Index Update * Change Order * OrderBy * Revert "Fix Error" This reverts commit d53d84d. * Revert "[EXILED::Events] BeingObserved event stolen (#91)" This reverts commit cc7c183. * Revert "`[Exiled::Events]` `[Exiled::API]` New event + new property (#31)" This reverts commit 043d9a9. * remove using * NW_Documentation * SCPSLRessources NW doc * Change * try to fix labeller try to fix labeler * Update DamageHandler Doc * Revert partially This reverts commit 03122a3. --------- Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com> Co-authored-by: X <24619207+Undid-Iridium@users.noreply.github.com> Co-authored-by: SrLicht <cerberus.tk.sl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
A new Scp173 event for when it's being observed
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other
#72 <----------------- See stolen pr