Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActivatingEventArgs): KnobStatus #193

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

JayXTQ
Copy link

@JayXTQ JayXTQ commented Nov 25, 2024

Description

Adds the knob status indicator to ActivatingEventArgs

What is the current behavior? (You can also link to an open issue here)
You have to grab the KnobStatus from Scp914.KnobStatus

What is the new behavior? (if this is a feature change)
Adds ActivatingEventArgs.KnobSetting


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771
Copy link

Can you add setting this value in patch?

@JayXTQ
Copy link
Author

JayXTQ commented Nov 25, 2024

I have no clue how to, I tried to add it based on the code for the other events but it didn't work sadly, I can try looking further though.

@JayXTQ
Copy link
Author

JayXTQ commented Nov 25, 2024

@VALERA771 after looking through the patches and me not knowing a single thing about IL and Transpilers, I gave up. But nameless told me there was an issue with the setter so I have fixed that, please review.

@VALERA771
Copy link

VALERA771 commented Nov 25, 2024

You sure that this value won't be overridden by event?

@JayXTQ
Copy link
Author

JayXTQ commented Nov 25, 2024

What do you mean exactly?

@VALERA771
Copy link

Oh this is activating... nvm

@JayXTQ
Copy link
Author

JayXTQ commented Nov 25, 2024

yeah, should be no issues here, please review tyvm :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants