Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scp330 interacting fix #184

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

Undid-Iridium
Copy link

@Undid-Iridium Undid-Iridium commented Nov 18, 2024

Description

Describe the changes
Fixing InteractingScp330EventArgs::Candy

What is the current behavior? (You can also link to an open issue here)
Candy is incorrect

What is the new behavior? (if this is a feature change)
Candy is correct

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing
    output_SCPSL_KbZxrtY2tk

@Undid-Iridium Undid-Iridium changed the base branch from master to dev November 18, 2024 03:15
@github-actions github-actions bot removed the API label Nov 18, 2024
Technically more accurate

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
@VALERA771
Copy link

Can you remove Scp330::CandyToAdd property pls

@github-actions github-actions bot added the API label Nov 20, 2024
@VALERA771 VALERA771 merged commit e5c54b7 into ExMod-Team:dev Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants