Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README-Русский.md (Russian) #181

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

intjiraya
Copy link

Description

Describe the changes
Updated the README-Русский.md file to improve clarity and accuracy in the Russian localization. Adjusted formatting and wording.

What is the current behavior? (You can also link to an open issue here)
The Russian localization of the README contained outdated or unclear phrasing.

What is the new behavior? (if this is a feature change)
The README-Русский.md file is now more accurately localized, with better readability and improved technical details.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes.

Other information:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really fluent in russian but I think you've missed commas in some places

@@ -15,7 +15,7 @@

<PropertyGroup>
<!-- This is the global version and is used for all projects that don't have a version -->
<Version Condition="$(Version) == ''">8.14.0</Version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this happened. It's almost my first time making a pull request. Sorry if something is wrong.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove editing this file (rollback or just change 1 back to 0)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit lost, can you explain it to me?

@intjiraya
Copy link
Author

In the new commit, I tweaked the commas a bit. Now everything seems correct. If there are any mistakes, please point them out.

@louis1706 louis1706 removed the Events label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants