[Exiled 9] The honored one😭 #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Events
Transpiler
API
base-game-bug
VALERA771
approved these changes
Oct 11, 2024
louis1706
requested changes
Oct 12, 2024
Comment on lines
43
to
67
| /// <summary> | ||
| /// Gets or sets the maximum radius of the grenade. | ||
| /// </summary> | ||
| public float MaxRadius | ||
| { | ||
| get => Projectile.MaxRadius; | ||
| set => Projectile.MaxRadius = value; | ||
| } | ||
| public float MaxRadius { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the multiplier for damage against <see cref="Side.Scp"/> players. | ||
| /// </summary> | ||
| public float ScpDamageMultiplier | ||
| { | ||
| get => Projectile.ScpDamageMultiplier; | ||
| set => Projectile.ScpDamageMultiplier = value; | ||
| } | ||
| public float ScpDamageMultiplier { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets how long the <see cref="EffectType.Burned"/> effect will last. | ||
| /// </summary> | ||
| public float BurnDuration | ||
| { | ||
| get => Projectile.BurnDuration; | ||
| set => Projectile.BurnDuration = value; | ||
| } | ||
| public float BurnDuration { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets how long the <see cref="EffectType.Deafened"/> effect will last. | ||
| /// </summary> | ||
| public float DeafenDuration | ||
| { | ||
| get => Projectile.DeafenDuration; | ||
| set => Projectile.DeafenDuration = value; | ||
| } | ||
| public float DeafenDuration { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets how long the <see cref="EffectType.Concussed"/> effect will last. | ||
| /// </summary> | ||
| public float ConcussDuration | ||
| { | ||
| get => Projectile.ConcussDuration; | ||
| set => Projectile.ConcussDuration = value; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets how long the fuse will last. | ||
| /// </summary> | ||
| public float FuseTime | ||
| { | ||
| get => Projectile.FuseTime; | ||
| set => Projectile.FuseTime = value; | ||
| } | ||
| public float ConcussDuration { get; set; } | ||
|
|
There was a problem hiding this comment.
I originally didn't want to change the Projectile API structure, but still came to the conclusion that storing prefabs for throwables was a bad idea from the point of view of all cases😭
And removing it and writing all the properties and their relations correctly, is much more safer
EXILED/Exiled.Events/Patches/Events/Scp939/ValidatingVisibility.cs
Outdated
Show resolved
Hide resolved
|
Why removing unitid argument? |
ok, when youll be free? |
louis1706
reviewed
Oct 23, 2024
louis1706
reviewed
Oct 23, 2024
EXILED/Exiled.Events/Patches/Events/Scp939/ValidatingVisibility.cs
Outdated
Show resolved
Hide resolved
On discord just dm me |
louis1706
reviewed
Oct 27, 2024
| else | ||
| { | ||
| // Doesn't really affect anything | ||
| writer.WriteUShort(400); |
There was a problem hiding this comment.
It's the zombie health show on client
There was a problem hiding this comment.
I just think to a point where it wouldn't be useless is when the player is spectated
louis1706
approved these changes
Oct 27, 2024
|
|
where ? |
louis1706
reviewed
Nov 12, 2024
| @@ -59,7 +59,7 @@ public static class Round | |||
| /// <summary> | |||
| /// Gets a value indicating whether the round is lobby or not. | |||
| /// </summary> | |||
| public static bool IsLobby => !(IsEnded || IsStarted); | |||
| public static bool IsLobby => ReferenceHub.LocalHub != null && !(IsEnded || IsStarted); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
ChangeAppearance, with posibility to change player appearance globaly/individualy/for specific teamSendingRoleas part of that API, for changing target role appearance for specific playerProjectileAPI changes, it was a my mistake to create a grenade prefab for each item, i deleted that unsafe part, and created new cool methods, and reorganized others.Scp018projectile states for activating it usingProjectile::ActivateIProjectileEventChangedNickname,ThrowingProjectile,Scp079::LosingSignal,Scp079::LostSignal,Scp929::CreatedAmnesticCloudEventArgseventsPickupSyncInfonw equality check\Scp330usingPlayer::AddItem(ItemType.Scp330)Scp939::ValidatingVisibilityreworkPlayer::UseItemlogic rework(not destroying item, same for consumables)CopyPropertiesfixWhat is the current behavior? (You can also link to an open issue here)
😭😭😭
What is the new behavior? (if this is a feature change)
📈📈📈
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
✅
Other information:
to lazy to write things like appearance api detailed, so in discord🤯
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other