Merge pull request #52 from EvoEsports/bugfix/interpolation-exception

Disable double interpolation test because of bad algorithm
EvoEsports · Feb 4, 2024 · f7aac28 · f7aac28
2 parents 9657b5e + eba7d3e
commit f7aac28
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 26 deletions.
diff --git a/src/ManiaTemplates/Lib/MtTransformer.cs b/src/ManiaTemplates/Lib/MtTransformer.cs
@@ -1182,24 +1182,25 @@ public static string ReplaceCurlyBraces(string value, Func<string, string> curly
     /// </summary>
     public static void CheckInterpolationRecursion(string value)
     {
-        var openCurlyBraces = 0;
-        foreach (var character in value.ToCharArray())
-        {
-            if (character == '{')
-            {
-                openCurlyBraces++;
-
-                if (openCurlyBraces >= 4)
-                {
-                    throw new InterpolationRecursionException(
-                        $"Double interpolation found in: {value}. You must not use double curly braces inside other double curly braces.");
-                }
-            }
-            else if (character == '}')
-            {
-                openCurlyBraces--;
-            }
-        }
+        //TODO: find proper algorithm
+        // var openCurlyBraces = 0;
+        // foreach (var character in value.ToCharArray())
+        // {
+        //     if (character == '{')
+        //     {
+        //         openCurlyBraces++;
+        //
+        //         if (openCurlyBraces >= 4)
+        //         {
+        //             throw new InterpolationRecursionException(
+        //                 $"Double interpolation found in: {value}. You must not use double curly braces inside other double curly braces.");
+        //         }
+        //     }
+        //     else if (character == '}')
+        //     {
+        //         openCurlyBraces--;
+        //     }
+        // }
     }
 
     /// <summary>

diff --git a/tests/ManiaTemplates.Tests/Lib/MtTransformerTest.cs b/tests/ManiaTemplates.Tests/Lib/MtTransformerTest.cs
@@ -133,14 +133,14 @@ public void Should_Import_Components_Recursively()
 ", output, ignoreLineEndingDifferences: true);
     }
 
-    [Fact]
-    public void Should_Throw_Interpolation_Recursion_Exception()
-    {
-        Assert.Throws<InterpolationRecursionException>(() =>
-            MtTransformer.CheckInterpolationRecursion("{{ {{ a }} {{ b }} }}"));
-        Assert.Throws<InterpolationRecursionException>(() =>
-            MtTransformer.CheckInterpolationRecursion("{{ {{ b }} }}"));
-    }
+    // [Fact]
+    // public void Should_Throw_Interpolation_Recursion_Exception()
+    // {
+    //     Assert.Throws<InterpolationRecursionException>(() =>
+    //         MtTransformer.CheckInterpolationRecursion("{{ {{ a }} {{ b }} }}"));
+    //     Assert.Throws<InterpolationRecursionException>(() =>
+    //         MtTransformer.CheckInterpolationRecursion("{{ {{ b }} }}"));
+    // }
 
     [Fact]
     public void Should_Throw_Curly_Brace_Count_Mismatch_Exception()