feat(Studio): choose line number padding based on visible rows #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
force-pushed
the
line-number-padding-visual
branch
from
0bd4c75
to
ec0770a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works but I don't like the code.
bottomRowis copied to 3 locations. It could be extracted to a function, but one location also wants visualBottomRow, topRow and visualTopRow.previousMaxDigitsto preventRecalcon every scroll eventoffscreenLinePadding. Where does the 3 come from? In theSearching...case it expands the padding on line 98, ingame at 97.2024-09-17.22-28-36.mp4