Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Commit

Permalink
Changes to pass environment in metabase params (#10982)
Browse files Browse the repository at this point in the history
* Changes to pass environment in metabase params

* Added migration
  • Loading branch information
hanzlamateen authored Aug 16, 2024
1 parent 983bcfc commit 3646b0b
Show file tree
Hide file tree
Showing 4 changed files with 81 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const metabaseSettingSchema = Type.Object(
}),
siteUrl: Type.String(),
secretKey: Type.String(),
environment: Type.String(),
crashDashboardId: Type.Optional(Type.String()),
expiration: Type.Number(),
createdAt: Type.String({ format: 'date-time' }),
Expand Down Expand Up @@ -70,6 +71,7 @@ export const metabaseSettingQueryProperties = Type.Pick(metabaseSettingSchema, [
'id',
'siteUrl',
'secretKey',
'environment',
'crashDashboardId'
])

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export async function seed(knex: Knex): Promise<void> {
{
siteUrl: process.env.METABASE_SITE_URL!,
secretKey: process.env.METABASE_SECRET_KEY!,
environment: process.env.METABASE_ENVIRONMENT!,
crashDashboardId: process.env.METABASE_CRASH_DASHBOARD_ID!,
expiration: isNaN(parseInt(process.env.METABASE_EXPIRATION!)) ? 10 : parseInt(process.env.METABASE_EXPIRATION!)
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
CPAL-1.0 License
The contents of this file are subject to the Common Public Attribution License
Version 1.0. (the "License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://github.com/EtherealEngine/etherealengine/blob/dev/LICENSE.
The License is based on the Mozilla Public License Version 1.1, but Sections 14
and 15 have been added to cover use of software over a computer network and
provide for limited attribution for the Original Developer. In addition,
Exhibit A has been modified to be consistent with Exhibit B.
Software distributed under the License is distributed on an "AS IS" basis,
WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License for the
specific language governing rights and limitations under the License.
The Original Code is Ethereal Engine.
The Original Developer is the Initial Developer. The Initial Developer of the
Original Code is the Ethereal Engine team.
All portions of the code written by the Ethereal Engine team are Copyright © 2021-2023
Ethereal Engine. All Rights Reserved.
*/

import { metabaseSettingPath } from '@etherealengine/common/src/schemas/integrations/metabase/metabase-setting.schema'
import type { Knex } from 'knex'

/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
export async function up(knex: Knex): Promise<void> {
await knex.raw('SET FOREIGN_KEY_CHECKS=0')

const tableExists = await knex.schema.hasTable(metabaseSettingPath)
if (tableExists) {
const environmentExists = await knex.schema.hasColumn(metabaseSettingPath, 'environment')
if (environmentExists === false) {
await knex.schema.alterTable(metabaseSettingPath, async (table) => {
table.string('environment').nullable()
})

const metabaseSettings = await knex.table(metabaseSettingPath).first()

if (metabaseSettings) {
await knex.table(metabaseSettingPath).update({
environment: process.env.METABASE_ENVIRONMENT
})
}
}
}
await knex.raw('SET FOREIGN_KEY_CHECKS=1')
}

/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
export async function down(knex: Knex): Promise<void> {
await knex.raw('SET FOREIGN_KEY_CHECKS=0')

const tableExists = await knex.schema.hasTable(metabaseSettingPath)
if (tableExists) {
const environmentExists = await knex.schema.hasColumn(metabaseSettingPath, 'environment')
if (environmentExists) {
await knex.schema.alterTable(metabaseSettingPath, async (table) => {
table.dropColumn('environment')
})
}
}

await knex.raw('SET FOREIGN_KEY_CHECKS=1')
}
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const metabaseCrashDashboard = async (context: HookContext<MetabaseUrlSer

const METABASE_SITE_URL = metabaseSetting.data[0].siteUrl
const METABASE_SECRET_KEY = metabaseSetting.data[0].secretKey
const ENVIRONMENT = metabaseSetting.data[0].environment
const EXPIRATION = metabaseSetting.data[0].expiration
const METABASE_CRASH_DASHBOARD_ID = metabaseSetting.data[0].crashDashboardId

Expand All @@ -56,7 +57,9 @@ export const metabaseCrashDashboard = async (context: HookContext<MetabaseUrlSer

const payload = {
resource: { dashboard: parseInt(METABASE_CRASH_DASHBOARD_ID) },
params: {},
params: {
environment: [ENVIRONMENT]
},
exp: Math.round(Date.now() / 1000) + EXPIRATION * 60
}

Expand Down

0 comments on commit 3646b0b

Please sign in to comment.