PSR-2 Formatting #25
Merged
PSR-2 Formatting #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove the merge commits? |
|
yup yup |
|
Looks like we couldn't avoid the conflicts 😠 |
added 2 commits
January 14, 2018 08:48
Pretty much all indentation related.
|
@Ethan3600 I rebased to fix the conflicts |
pmclain
commented
Jan 14, 2018
| } | ||
| } | ||
|
|
||
| public function dispatchCron($jobId = null, $jobCode, $schedule = null) |
There was a problem hiding this comment.
This was the only remaining item picked up by the linter/sniffer I was using. Arguments with default values should be after required arguments, but it didn't look right to have the id after the job code. Any thoughts?
There was a problem hiding this comment.
I agree with you, the ID should take precedence. Let's let it slide this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
di.xmlRelated to #22