Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize ba #1902

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

Minimize ba #1902

wants to merge 40 commits into from

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented May 22, 2024

ninja bench-ba-reverse
3 incorrect and 12 correct entries are alternating.
Which is suspicious because we fill it using
for (int j = 0; j < BA_NCAMPARAMS + 3 + 1; j++) with the constant = 11, thus 11+3+1=15
the error is in the first 3 fields of the 15 entries, thus corresponds exactly to the rot subfield

Enzyme get's the following code wrong:
let w = rot.map(|v| v * theta_inverse);
A for loop over
w[i] = rot[i] * theta_inverse; gives the correct derivatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants