Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100 player lobby (Ported from crowded) #831

Draft
wants to merge 7 commits into
base: 100PlayerLobbySupport
Choose a base branch
from

Conversation

ryuk201198
Copy link
Collaborator

No description provided.

@Pietrodjaowjao
Copy link
Contributor

apparently github reverted the entire rolebase while trying to fix conflicts

@Pietrodjaowjao
Copy link
Contributor

its extremely hard to do the other part but its partially done, i will finish tomorrow ig

@Tommy-XL Tommy-XL added the Enhancement New feature or request label Apr 17, 2024
@ryuk201198 ryuk201198 marked this pull request as draft April 22, 2024 12:47
@Tommy-XL
Copy link
Collaborator

Tommy-XL commented May 9, 2024

Actually the Crowded code has some problems with null errors, so I'm not sure if it's worth merging

@NikoCat233
Copy link
Collaborator

I still dont think tohe should include crowded feature directly

@NikoCat233
Copy link
Collaborator

NikoCat233 commented May 9, 2024

Actually the Crowded code has some problems with null errors, so I'm not sure if it's worth merging

null is probably caused by reference to numberoptions in gameoptionsmenu, where tohe will build a tab without number options and crowded try to search for it

i should have fixed it, see the pr on crowded

@Wannacry-ops
Copy link

from where the 100 players will be placed from where you create it or by commands and if so, what would it be?

@Ultradragon005
Copy link
Contributor

ya'll, this is crazy

@NikoCat233
Copy link
Collaborator

should be replaced by this
https://github.com/NikoCat233/CrowdedMod/releases/tag/v0.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants