Fix StandardGpuResources memory leak
#81
Conversation
|
|
||
| // Try to allocate gpu resources multiple times in a loop. | ||
| // If resources are not properly deallocated this will cause out-of-memory error. | ||
| for _ in 0..50 { |
There was a problem hiding this comment.
Going up to 16 was enough for my machine, but I guess it depends on how much temporary memory is allocated per instance. Maybe one could raise the temporary memory allocated so that it fails faster, but the worth of doing this, which is checking that the new Drop impl is called, is too low to block this.
There was a problem hiding this comment.
This test can be considered just as reproducer of the issue. It should not be run every time, or maybe it should be removed at all because it consumes a lot of resources (all GPU memory) just to ensure that destructor is called.
There was a problem hiding this comment.
I'll go ahead and merge as-is, because there is not that much mental overhead in having an ignored test.
No description provided.