[ul] Recover API compatibility with 0.7.1 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- revert changes to association::client::Error so that it stays backwards compatible - re-export PDataReader, PDataWriter, and AsyncPDataWriter in association module - re-export PDU constants in pdu::reader module (as deprecated) - re-export error types in PDU reader and writer modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back or reverts some parts of the API changed by #542 so that there are no breaking changes.
Summary
association::client::Errorso that the enum type stays backwards compatiblePDataReader,PDataWriter, andAsyncPDataWriterinassociationmodulepdu::readermodule (as deprecated so that users prefer the ones inpdu)dicom_ul::pdu