Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pixeldata] Handle empty NumberOfFrames tags #576

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[pixeldata] Handle empty NumberOfFrames tags #576

merged 1 commit into from
Oct 23, 2024

Conversation

abustany
Copy link
Contributor

I'm not sure of what the semantic difference between "absent tag" and "empty tag" is, but I do have some XRays with an empty "NumberOfFrames" tag.

@Enet4 Enet4 added enhancement A-lib Area: library C-pixeldata Crate: dicom-pixeldata labels Oct 22, 2024
@Enet4 Enet4 self-requested a review October 22, 2024 11:09
Enet4
Enet4 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds fair. Providing an empty Number Of Frames does not seem compliant from my interpretation of the standard, but is simple to handle with hardly any downsides. Thank you. 👍

@Enet4 Enet4 merged commit dee9a34 into Enet4:master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
A-lib Area: library C-pixeldata Crate: dicom-pixeldata enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abustany @Enet4