-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(main): add argument --no-banner #220
base: master
Are you sure you want to change the base?
Conversation
hi @0xlildoudou, thanks for the PR! can you help me understand under what use case(s) this will be helpful to users? :D |
Tooling integration man, we're all waiting for it ! :D |
Hi @0xInfection , for my part, this is one of the improvements I've added to the tools. I launch the tool in a Kubernetes cluster and I rely on the stdout output to know if everything goes well during the launch. The banner is therefore a bit problematic. |
I see. For the integrations was the output to file flag not working for you enough? What improvements can you suggest that would make the output to file feature more useful? |
I use the output file with the "--no-banner" as a same time in my fork. I have work for add wafw00f status log for container integration but actually it's dirty 😅 |
@0xInfection what's next for this PR ? |
hi @0xlildoudou! I'm just confused around the use-case yet, and I am looking for suggestions where the output to file (json/csv) is not working well for your usecase. Maybe you can help suggest how we can improve your integration? |
Which category is this pull request?
Where has this been tested?
Does this close any currently open issues?
no
Does this add any new dependency?
no
Does this add any new command line switch/argument?
add new argument
--no-banner
for remove banner (default false)Any other comments you would like to make?