Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): add argument --no-banner #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0xlildoudou
Copy link

@0xlildoudou 0xlildoudou commented Oct 29, 2024

Which category is this pull request?

  • A new feature/enhancement.
  • Fix an issue/feature-request.
  • An improvement to existing modules.
  • Other (Please mention below).

Where has this been tested?

  • Python Version
    • v3.x
    • v2.x
  • Operating System:
    • [ x] Linux (debian 12)
    • Windows
    • MacOS

Does this close any currently open issues?

no

Does this add any new dependency?

no

Does this add any new command line switch/argument?

add new argument --no-banner for remove banner (default false)

Any other comments you would like to make?

@0xInfection
Copy link
Collaborator

hi @0xlildoudou, thanks for the PR! can you help me understand under what use case(s) this will be helpful to users? :D

@laluka
Copy link

laluka commented Nov 1, 2024

Tooling integration man, we're all waiting for it ! :D

@0xlildoudou
Copy link
Author

Hi @0xInfection ,

for my part, this is one of the improvements I've added to the tools. I launch the tool in a Kubernetes cluster and I rely on the stdout output to know if everything goes well during the launch. The banner is therefore a bit problematic.
In addition, many automated tools need to retrieve the stdout, so the banner is problematic.
By default, the banner remains displayed. It's only a minor addition to the tool.

@0xInfection
Copy link
Collaborator

I see. For the integrations was the output to file flag not working for you enough? What improvements can you suggest that would make the output to file feature more useful?

@0xlildoudou
Copy link
Author

I use the output file with the "--no-banner" as a same time in my fork.
stdout --> wafw00f status
output file --> wafw00f status.

I have work for add wafw00f status log for container integration but actually it's dirty 😅

@0xlildoudou
Copy link
Author

@0xInfection what's next for this PR ?

@0xInfection
Copy link
Collaborator

hi @0xlildoudou! I'm just confused around the use-case yet, and I am looking for suggestions where the output to file (json/csv) is not working well for your usecase. Maybe you can help suggest how we can improve your integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants