Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swap): extract hadcoded value into constant #3718

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix(swap): extract hadcoded value into constant #3718

merged 2 commits into from
Oct 29, 2024

Conversation

nistadev
Copy link
Contributor

Description

  • Extract the hardcoded value of page-error to the Routes constants.

@vsubhuman vsubhuman added this to the 5.4.300 milestone Oct 29, 2024
@vsubhuman vsubhuman merged commit d2b7dbe into release/5.4.300 Oct 29, 2024
6 of 8 checks passed
@vsubhuman vsubhuman deleted the fix/page-error-refactor branch October 29, 2024 13:46
@vsubhuman vsubhuman mentioned this pull request Oct 30, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.300
Development

Successfully merging this pull request may close these issues.
2 participants
@nistadev @vsubhuman