Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector signTx witnesses CIP95 certificates and tx fields #3296

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

yushih
Copy link
Collaborator

@yushih yushih commented Sep 25, 2023

No description provided.

@neuodev
Copy link
Contributor

neuodev commented Sep 25, 2023

Base automatically changed from feat/YOEXT-800/cip95-connector-endpoints to feat/YOEXT-797/cip95 September 25, 2023 08:39
@vsubhuman vsubhuman added this to the 4.22.700 milestone Sep 25, 2023
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -479,6 +479,12 @@ export async function connectorGetUnusedAddresses(wallet: PublicDeriver<>): Prom
export async function connectorGetDRepKey(
wallet: PublicDeriver<>,
): Promise<string> {
return (await _getDRepKeyAndAddressing(wallet))[0].to_hex();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@vsubhuman vsubhuman merged commit 5cd1dd0 into feat/YOEXT-797/cip95 Sep 26, 2023
12 of 18 checks passed
@vsubhuman vsubhuman deleted the feat/YOEXT-799/cip95-signTx branch September 26, 2023 10:04
@vsubhuman vsubhuman mentioned this pull request Sep 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants