Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dapps): revamp connected dApps screen #3275

Merged
merged 8 commits into from
Oct 8, 2023
Merged

feat(dapps): revamp connected dApps screen #3275

merged 8 commits into from
Oct 8, 2023

Conversation

nistadev
Copy link
Contributor

Screenshots

No Dapps
image

With Dapps
image

Dapp hover
image

@nistadev nistadev changed the base branch from develop to feat/YOEXT-672/revamp-txs-page August 30, 2023 21:56
@neuodev
Copy link
Contributor

neuodev commented Aug 30, 2023

[autoscirpt] Jira Ticket: Connected DApps Page

@neuodev neuodev changed the title Feat/yoext 681/revamp dapp connections feat(dapps): revamp connected dApps screen Aug 31, 2023
@neuodev neuodev marked this pull request as ready for review September 21, 2023 08:04
neuodev
neuodev suggested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@neuodev neuodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet information is missing.

Screenshot 2023-09-21 at 11 16 39 AM

...ges/yoroi-extension/app/components/dapp-connector/ConnectedWebsites/ConnectedWebsitesPage.js Outdated Show resolved Hide resolved
...ges/yoroi-extension/app/components/dapp-connector/ConnectedWebsites/ConnectedWebsitesPage.js Outdated Show resolved Hide resolved
packages/yoroi-extension/app/i18n/locales/en-US.json Outdated Show resolved Hide resolved
@neuodev
Copy link
Contributor

neuodev commented Sep 21, 2023

Wallet information is missing.

Screenshot 2023-09-21 at 11 16 39 AM

Fixed 👇

Preview

Screenshot 2023-09-21 at 11 31 15 AM

@neuodev
Copy link
Contributor

neuodev commented Sep 21, 2023

Note: flow errors in this PR are caused by the "target" branch. should be fixed their first.

Base automatically changed from feat/YOEXT-672/revamp-txs-page to develop September 22, 2023 07:38
@vsubhuman vsubhuman added this to the 5.0.0 milestone Oct 7, 2023
vsubhuman
vsubhuman reviewed Oct 8, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 228ee0b into develop Oct 8, 2023
6 of 12 checks passed
@vsubhuman vsubhuman deleted the feat/YOEXT-681/revamp-dapp-connections branch October 8, 2023 18:52
@vsubhuman vsubhuman mentioned this pull request Oct 8, 2023
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@neuodev neuodev neuodev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0 (revamp, analytics)
Development

Successfully merging this pull request may close these issues.
3 participants
@nistadev @neuodev @vsubhuman