Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(voting): revamp voting page & dialogs #3273

Merged
merged 7 commits into from
Sep 28, 2023
Merged

feat(voting): revamp voting page & dialogs #3273

merged 7 commits into from
Sep 28, 2023

Conversation

nistadev
Copy link
Contributor

@nistadev nistadev commented Aug 29, 2023 •
edited
Loading

Screenshots

Main page
image

Register dialog
image

image

@neuodev
Copy link
Contributor

neuodev commented Aug 29, 2023

[autoscirpt] Jira Ticket: Catalyst Voting

@neuodev neuodev changed the title Feat/yoext 679/catalyst voting revamp feat(voting): revamp voting page & dialogs Aug 30, 2023
@neuodev neuodev self-requested a review September 21, 2023 08:44
@neuodev neuodev self-assigned this Sep 21, 2023
neuodev
neuodev reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@neuodev neuodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nistadev This branch has unrelated changes. Can you please include only the commits related to this PR?

Base automatically changed from feat/YOEXT-672/revamp-txs-page to develop September 22, 2023 07:38
@neuodev
Merge branch 'develop' of https://github.com/Emurgo/yoroi-frontend in…
36b1ace 
…to feat/YOEXT-679/catalyst-voting-revamp
@neuodev neuodev marked this pull request as ready for review September 26, 2023 08:16
@neuodev
Copy link
Contributor

neuodev commented Sep 26, 2023

@nistadev This branch has unrelated changes. Can you please include only the commits related to this PR?

Commit no longer appearing after changing the "base" branch to "develop".

Conflicts with develop is resolved.

neuodev
neuodev approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@neuodev neuodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nistadev! LGTM!

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nistadev
Copy link
Contributor Author

@nistadev This branch has unrelated changes. Can you please include only the commits related to this PR?

Commit no longer appearing after changing the "base" branch to "develop".

Conflicts with develop is resolved.

This are the commits related to the branch:

@vsubhuman vsubhuman added this to the 5.0.0 milestone Sep 28, 2023
@vsubhuman vsubhuman merged commit 9aa77fb into develop Sep 28, 2023
4 of 11 checks passed
@vsubhuman vsubhuman deleted the feat/YOEXT-679/catalyst-voting-revamp branch September 28, 2023 14:36
@vsubhuman vsubhuman mentioned this pull request Oct 8, 2023
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuodev neuodev neuodev approved these changes

@vsubhuman vsubhuman vsubhuman approved these changes

Assignees

@neuodev neuodev

Labels
None yet
Projects
None yet
Milestone
5.0.0 (revamp, analytics)
Development

Successfully merging this pull request may close these issues.
3 participants
@nistadev @neuodev @vsubhuman