Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/yoext 752/dapp tests fix #3270

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Tests/yoext 752/dapp tests fix #3270

merged 12 commits into from
Aug 28, 2023

Conversation

Nebyt
Copy link
Contributor

@Nebyt Nebyt commented Aug 28, 2023

No description provided.

@neuodev
Copy link
Contributor

neuodev commented Aug 28, 2023

[autoscirpt] Jira Ticket: Fix dApp tests

Nebyt
Nebyt commented Aug 28, 2023
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/dapp-check

vsubhuman
vsubhuman reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nebyt Nebyt marked this pull request as ready for review August 28, 2023 13:44
vsubhuman
vsubhuman approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@vsubhuman vsubhuman merged commit e55e88d into develop Aug 28, 2023
9 of 21 checks passed
@vsubhuman vsubhuman deleted the tests/YOEXT-752/dapp-tests-fix branch August 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@neuodev neuodev Awaiting requested review from neuodev

@nistadev nistadev Awaiting requested review from nistadev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nebyt @neuodev @vsubhuman