feat(settings): revamp settings page layout (all subpages) #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neuodev
commented
Aug 16, 2023
•
neuodev
commented
- General
- Blockchain
- Wallet
- Terms of Service Agreement
- Support / Logs
- Level of Complexity
|
[autoscirpt] Jira Ticket: Settings |
nistadev
reviewed
Aug 17, 2023
packages/yoroi-extension/app/components/profile/terms-of-use/TermsOfUseText.scss
Outdated
Show resolved
Hide resolved
nistadev
reviewed
Aug 17, 2023
| )} | ||
| <Box | ||
| sx={{ | ||
| width: isRevampLayout ? '506px' : '100%', |
There was a problem hiding this comment.
Better use the prop maxWidth to limit width, if not, will cause horizontal scroll for smaller layouts.
nistadev
reviewed
Aug 17, 2023
| @@ -17,6 +17,7 @@ const RevampButtonCommonProps: Object = { | |||
| '&.MuiButton-sizeLarge': { height: '56px' }, | |||
| '&.MuiButton-sizeMedium': { padding: '10px', height: '48px' }, | |||
| '&.MuiButton-sizeSmall': { padding: '7px', height: '32px' }, | |||
| '&.MuiButton-sizeFlat': { padding: '13px 24px', hight: 'unset' }, | |||
There was a problem hiding this comment.
Suggested change
| '&.MuiButton-sizeFlat': { padding: '13px 24px', hight: 'unset' }, | |
| '&.MuiButton-sizeFlat': { padding: '13px 24px', height: 'unset' }, |
|
SonarQube Quality Gate
|
…amp-settings-page # Conflicts: # packages/yoroi-extension/app/components/layout/TopBarLayout.js # packages/yoroi-extension/app/containers/profile/TermsOfUsePage.js # packages/yoroi-extension/app/containers/wallet/Receive.js # packages/yoroi-extension/app/containers/wallet/WalletReceivePage.js # packages/yoroi-extension/app/styles/overrides/revamp/Button.js # packages/yoroi-extension/app/styles/overrides/revamp/InputLabel.js
|
SonarQube Quality Gate
|
vsubhuman
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.