Merge pull request #3352 from Emurgo/feat/YOEXT-783/pool-owner-witness

[4.23.200] enable to register as pool owner
Emurgo · Nov 18, 2023 · 4f0a873 · 4f0a873
2 parents aa24fc2 + ebaaa26
commit 4f0a873
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/packages/yoroi-extension/chrome/extension/connector/api.js b/packages/yoroi-extension/chrome/extension/connector/api.js
@@ -595,7 +595,7 @@ function getTxRequiredSigningKeys(
   return set;
 }
 
-function getCip95RequiredSignKeys(
+function getCertificatesRequiredSignKeys(
   txBody: RustModule.WalletV4.TransactionBody,
 ): Set<string> {
   const result: Set<string> = new Set();
@@ -679,6 +679,14 @@ function getCip95RequiredSignKeys(
         }
         continue;
       }
+      const poolRegCert = cert.as_pool_registration();
+      if (poolRegCert) {
+        const hashes = poolRegCert.pool_params().pool_owners();
+        for (let j = 0; j < hashes.len(); j++) {
+          result.add(hashes.get(j).to_hex());
+        }
+        continue;
+      }
     }
   }
 
@@ -765,13 +773,10 @@ async function __connectorSignCardanoTx(
     throw new Error(`missing chains functionality`);
   }
 
-  const requiredTxSignKeys = getTxRequiredSigningKeys(txBody);
-  const requiredScriptSignKeys = getScriptRequiredSigningKeys(witnessSet, RustModule);
-  const requiredCip95SignKeys = getCip95RequiredSignKeys(txBody);
   const totalAdditionalRequiredSignKeys = new Set<string>([
-    ...requiredTxSignKeys,
-    ...requiredScriptSignKeys,
-    ...requiredCip95SignKeys,
+    ...getTxRequiredSigningKeys(txBody),
+    ...getScriptRequiredSigningKeys(witnessSet, RustModule),
+    ...getCertificatesRequiredSignKeys(txBody),
   ]);
 
   console.log('totalAdditionalRequiredSignKeys', [...totalAdditionalRequiredSignKeys]);

diff --git a/packages/yoroi-extension/package-lock.json b/packages/yoroi-extension/package-lock.json
diff --git a/packages/yoroi-extension/package.json b/packages/yoroi-extension/package.json
@@ -1,6 +1,6 @@
 {
   "name": "yoroi",
-  "version": "4.23.100",
+  "version": "4.23.200",
   "description": "Cardano ADA wallet",
   "scripts": {
     "dev-mv2": "rimraf dev/ && babel-node scripts-mv2/build --type=debug --env 'mainnet'",