Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped scipp to 23.08 #65

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Bumped scipp to 23.08 #65

merged 5 commits into from
Jan 10, 2024

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented Jan 8, 2024

New version of scipp uses plopp as default plotting tool.

plot.py

  • plopp doesn't allow for variance in coords data.
  • changed to one argument per line (easier to see differences in git)
  • removed try / expect to handle code logic

In pyproject.toml:

  • bumped scipp to 23.08
  • dev dependencies
    • alphabetic order
    • added plopp

Adjusted jupyter notebooks to new plotting functionality.

Adjust read in data to the more strict requirements by scipp (removed plural s in example data)

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8c383c) 97.86% compared to head (aaba24d) 97.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #65   +/-   ##
========================================
  Coverage    97.86%   97.86%           
========================================
  Files           41       41           
  Lines         3050     3050           
========================================
  Hits          2985     2985           
  Misses          65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andped10 andped10 requested a review from rozyczko January 8, 2024 10:21
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two minor issues raised, once resolved the branch can be merged.

docs/_static/d70d2o.ort Outdated Show resolved Hide resolved
docs/solvation.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@andped10 andped10 merged commit eab0d31 into develop Jan 10, 2024
31 checks passed
@andped10 andped10 deleted the plopp-plotting-more-strict-scipp branch January 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants