Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitting tests/functionality fixed #59

Merged
merged 3 commits into from
Dec 5, 2023
Merged

fitting tests/functionality fixed #59

merged 3 commits into from
Dec 5, 2023

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Dec 5, 2023

changed dependency to fixed easyCore, which seems to have been failing for variables with units.
Also, pinned scipp version.

@rozyczko rozyczko added the bug Something isn't working label Dec 5, 2023
Copy link
Collaborator

@andped10 andped10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Do you know when the fix will make it to master on EasyCore?

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40b6e44) 97.86% compared to head (490e079) 97.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #59   +/-   ##
========================================
  Coverage    97.86%   97.86%           
========================================
  Files           41       41           
  Lines         3050     3050           
========================================
  Hits          2985     2985           
  Misses          65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rozyczko rozyczko merged commit 07e8ece into develop Dec 5, 2023
25 checks passed
@rozyczko rozyczko deleted the fixed_unit_tests branch December 5, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants