-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
201 move reporting to the lib #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the example. The code looks good to me. The only question is why methods like count_free_parameters
or count_fixed_parameters
are not part of the Project
class, but moved to utils.py
?
You are right, they are now properties of the project |
There were too many problems with CodeFactor reporting an issue when count functionality was becoming a property of Project so it was moved back to utils |
Functionality to generate a project summary.
Summary is based on html template.
Have left some commented out parts in the templates for info that might be added in later
Some minor corrections in other parts of the code.
To convert html to pdf we use the package:
xhtml2pdf
Only summaries going to files contain images