Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 move reporting to the lib #202

Merged
merged 51 commits into from
Nov 21, 2024
Merged

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented Nov 19, 2024

Functionality to generate a project summary.

Summary is based on html template.

Have left some commented out parts in the templates for info that might be added in later

Some minor corrections in other parts of the code.

To convert html to pdf we use the package: xhtml2pdf

Only summaries going to files contain images

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 added the chore Chore changes to the code label Nov 20, 2024
@andped10 andped10 added feature New functionality or request and removed chore Chore changes to the code labels Nov 20, 2024
@andped10 andped10 marked this pull request as ready for review November 20, 2024 07:02
Copy link
Member

@AndrewSazonov AndrewSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the example. The code looks good to me. The only question is why methods like count_free_parameters or count_fixed_parameters are not part of the Project class, but moved to utils.py?

@andped10
Copy link
Collaborator Author

Thanks for adding the example. The code looks good to me. The only question is why methods like count_free_parameters or count_fixed_parameters are not part of the Project class, but moved to utils.py?

You are right, they are now properties of the project

@andped10
Copy link
Collaborator Author

Thanks for adding the example. The code looks good to me. The only question is why methods like count_free_parameters or count_fixed_parameters are not part of the Project class, but moved to utils.py?

You are right, they are now properties of the project

There were too many problems with CodeFactor reporting an issue when count functionality was becoming a property of Project so it was moved back to utils

@andped10 andped10 merged commit 0cd7dcb into develop Nov 21, 2024
32 checks passed
@andped10 andped10 deleted the 201-move-reporting-to-the-lib branch November 21, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants