-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
191 adjust model and modelcollection to hold functionality from app #192
191 adjust model and modelcollection to hold functionality from app #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I have a few comments
m = Layer(name='Layer m') | ||
|
||
# Then | ||
p.add_layer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own understanding: What is add_layer()
doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add_layer
appends a new layer to the given layer collection. If called without an argument it just adds a default layer. If called with a layer as argument it adds that given layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Minor questions raised
Project now have methods to expose calculated data and experimental data
Model now have a color
Consolidated collections