Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

191 adjust model and modelcollection to hold functionality from app #192

Conversation

andped10
Copy link
Collaborator

Project now have methods to expose calculated data and experimental data

Model now have a color

Consolidated collections

@andped10 andped10 added the chore Chore changes to the code label Oct 10, 2024
Copy link
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have a few comments

m = Layer(name='Layer m')

# Then
p.add_layer()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my own understanding: What is add_layer() doing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_layer appends a new layer to the given layer collection. If called without an argument it just adds a default layer. If called with a layer as argument it adds that given layer.

Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
Minor questions raised

src/easyreflectometry/data/data_store.py Outdated Show resolved Hide resolved
@andped10 andped10 merged commit dc2ea11 into develop Oct 11, 2024
32 checks passed
@andped10 andped10 deleted the 191-adjust-model-and-modelcollection-to-hold-functionality-from-app branch October 11, 2024 09:45
@andped10 andped10 linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore changes to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust Model and ModelCollection to hold functionality from App
3 participants