Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

158 magnetism in refl1d #159

Merged
merged 28 commits into from
Jun 11, 2024
Merged

158 magnetism in refl1d #159

merged 28 commits into from
Jun 11, 2024

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented May 13, 2024

Another step in the process of getting the ability to handle magnetism into EasyReflectometry.

First version of tutorial demonstrating how the magnetism of layers can be set.

I know the way to set the magnetism of a layer should be more elegant, but consider this a step towards that.

Issues that should be handled after this PR:
#168
#167

@andped10 andped10 added the feature New functionality or request label May 13, 2024
@andped10 andped10 linked an issue May 13, 2024 that may be closed by this pull request
Copy link
Collaborator

@jfkcooper jfkcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggested rewordings and comments on the notebook, but otherwise looking good

docs/src/dictionay.rst Outdated Show resolved Hide resolved
docs/src/dictionay.rst Outdated Show resolved Hide resolved
docs/src/dictionay.rst Outdated Show resolved Hide resolved
docs/src/tutorials/magnetism.ipynb Show resolved Hide resolved
docs/src/tutorials/magnetism.ipynb Outdated Show resolved Hide resolved
docs/src/tutorials/magnetism.ipynb Outdated Show resolved Hide resolved
docs/src/tutorials/magnetism.ipynb Outdated Show resolved Hide resolved
@andped10 andped10 requested a review from jfkcooper June 11, 2024 07:32
Copy link
Collaborator

@jfkcooper jfkcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andped10 andped10 merged commit de4572f into develop Jun 11, 2024
26 checks passed
@andped10 andped10 deleted the 158-magnetism-in-refl1d branch June 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magnetism in Refl1d
3 participants