Protect harbor with sealed secrets. #44
Merged
+70
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft, because this is untested so far. You may want to have a look already, @jankovicgd. |
pantierra
force-pushed
the
feature/harbor-sealed-secret
branch
from
e205958
to
ba1112d
Compare
|
Completed this PR, but still untested. |
|
Awesome, @pantierra! How do we test this? If it is easiest, it would be fine to merge this (after review from @jankovicgd) and deploy to develop - that is what it is for... |
rconway
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches harbor's root user authentication to sealed secrets.
Related to EOEPCA/data-access#82