Use a library for sloppy date parsing #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesname
force-pushed
the
feature/date_parsing_lib
branch
from
2d48bd2
to
caac47d
Compare
mikesname
force-pushed
the
feature/date_parsing_lib
branch
6 times, most recently
from
cfb4c80
to
919bec9
Compare
mikesname
changed the title
mikesname
force-pushed
the
feature/date_parsing_lib
branch
from
919bec9
to
0c44cd7
Compare
Remove support for dangerous Bundesarchiv date range format (1906/08, meaning the years) and add support for e.g. `1933 ca.` and `1939/09 - 1945/05`. Refactor some confusing parsing code (and intro- duce some more of our own for ranges.)
mikesname
force-pushed
the
feature/date_parsing_lib
branch
from
0c44cd7
to
bbf4afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for dangerous Bundesarchiv date range format (1906/08, meaning the years) and add support for e.g.
1933 ca.and1939/09 - 1945/05. More refactoring and tests are needed here.