Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cleanup more scalable and perform deletions in batches #1479

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

mikesname
Copy link
Contributor

No description provided.

@mikesname mikesname force-pushed the bugfix/batch_cleanup_deletions branch from 4419507 to 6de90e6 Compare September 8, 2023 14:43
@mikesname mikesname changed the title Bugfix/batch cleanup deletions NOT FOR MERGING Make cleanup more scalable and perform deletions in batches Sep 13, 2023
This avoids overloading the backend. It unfortunately also requires
more tricky actor logic and UI to implement, but should hopefully
be more reliable.
This was an issue when some rows were selected and the `all` check
toggled on or off, leaving rows in the opposite state.

Also make the header sticky, which seems to work now with
border-collapse on the table disabled and border-spacing: 0.
This mainly adds a space between the `function` keyword and the
parens on JS anonymous functions, which I did not know was a style
recommendation.
@mikesname mikesname merged commit a723865 into EHRI:master Sep 13, 2023
1 check passed
@mikesname mikesname deleted the bugfix/batch_cleanup_deletions branch September 13, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant