Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator: Allow AF Info field to contain missing value. #130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blankenberg
Copy link

Also, Fix for text report AF error.

@jmmut
Copy link
Contributor

jmmut commented Mar 28, 2018

Good spot! thanks for the contribution.

The code you added to allow missing values not only allows simple missing values, e.g. AF=. but also to mixed (missing and non-missing) values such as AF=.,0.3, which we need to check with the spec to see if it's valid before merging.

Also, this made us realise we need to allow missing in other fields as well.

@blankenberg
Copy link
Author

Great, let me know what you are able to decipher as far as the spec is concerned.

I'll also just briefly mention that the original error was quite cryptic (in contrast to other 'real' validation errors) as it was just an uncaught stold conversion. It may be worthwhile to check for additional places in the code and where this sort of unchecked error could occur and provide one of the much more meaningful errors that vcf_validator generally provides.

./vcf_validator -i ../../test.vcf 
[info] Reading from input file...
[error] stold

@cyenyxe cyenyxe changed the base branch from develop to master April 3, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants