Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator prev version in upgrade e2e test to 1.3.2. #4123

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

andriisoldatenko
Copy link
Contributor

@andriisoldatenko andriisoldatenko commented Nov 28, 2024

Description

Bump operator prev version in upgrade e2e test to 1.3.2.

Bonus:

  • I've fixed slack integration.
  • removed redundant WaitFromDaemonSetPrevDk and replaced with WaitFromDaemonset

How can this be tested?

Run make test/e2e/release

@andriisoldatenko andriisoldatenko changed the base branch from main to release-1.4 November 28, 2024 18:25
@andriisoldatenko andriisoldatenko marked this pull request as ready for review November 28, 2024 18:26
@andriisoldatenko andriisoldatenko requested a review from a team as a code owner November 28, 2024 18:26
@andriisoldatenko andriisoldatenko requested review from gkrenn, 0sewa0, chrismuellner, albertogdd, waodim, aorcholski and luhi-DT and removed request for a team November 28, 2024 18:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.50%. Comparing base (83a94b6) to head (3193c31).
Report is 1 commits behind head on release-1.4.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.4    #4123   +/-   ##
============================================
  Coverage        64.50%   64.50%           
============================================
  Files              400      400           
  Lines            26760    26760           
============================================
  Hits             17261    17261           
  Misses            8139     8139           
  Partials          1360     1360           
Flag Coverage Δ
unittests 64.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran tests locally and worked

@andriisoldatenko andriisoldatenko enabled auto-merge (squash) December 2, 2024 12:53
@andriisoldatenko andriisoldatenko changed the title fixup e2e tests release 1 4 Bump operator prev version in upgrade e2e test to 1.3.2. Dec 2, 2024
@andriisoldatenko andriisoldatenko merged commit a3f024a into release-1.4 Dec 2, 2024
16 checks passed
@andriisoldatenko andriisoldatenko deleted the fixup-e2e-tests-release-1-4 branch December 2, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants