-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearPicsCache function to reduce memory usage and store job types #444
base: master
Are you sure you want to change the base?
Conversation
if (k.type && [ EMsg.ClientPICSChangesSinceRequest, EMsg.ClientPICSProductInfoRequest, EMsg.ClientPICSAccessTokenRequest ].includes(k.type)) { | ||
delete this._jobs[e]; | ||
clearTimeout(this._jobCleanupTimers[e]); | ||
delete this._jobCleanupTimers[e]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause any outstanding getProductChanges
, getProductInfo
, or getProductAccessToken
requests to time out, which isn't ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that of great concern if the user clears the cache manually and intentionally?
I'd assume any related pending requests aren't needed then anymore. This would be something worth noting in the README and JsDoc though
If your use-case is simply that you need to know which apps you own, I'd rather come up with a better way of determining that without needing to enable the entire pics cache. |
If there is a better way of determining the owned apps then I'll look into it, thanks Edit: I completely overlooked that |
This PR adds a clearPicsCache() function to reduce memory usage if content is not needed anymore.
In order for the garbage collector to instantly free the memory being used we need to filter the
jobs
object.I added a
type
property to everyjobs
entry which stores theEMsg
value of the associated request. This allows us to only filter PICS related entries instead of needing to nuke the whole object.Related forum thread:
https://dev.doctormckay.com/topic/4476-advice-needed-on-clearing-picscache-im-struggling-with-ram-usage/
Note: I updated the documentation but I didn't fill out the required version as I don't know which version number you'll choose