Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirmation prompts: abort with unique messages #1314

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

sielicki
Copy link
Contributor

If an install is attempted, it fails near the end, and an uninstall is declined by the user, state specifically that an uninstall was not done, don't report that nothing was done.

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

sielicki and others added 2 commits November 24, 2024 01:19
If an install is attempted, it fails near the end, and an uninstall is declined
by the user, state specifically that an uninstall was not done, don't report
that nothing was done.

Signed-off-by: Nicholas Sielicki <nix@opensource.nslick.com>
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit slightly rewording the messages. Thanks!

@cole-h cole-h enabled auto-merge (squash) November 25, 2024 15:41
@cole-h cole-h merged commit 10e6075 into DeterminateSystems:main Nov 25, 2024
21 checks passed
@cole-h cole-h added this to the 0.30.1 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants