-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support from localization based on browser and languages #805
Conversation
0b5fd2a
to
4055cdd
Compare
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Im not sure if these strings are being used
|
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
It does indeed look like those are unused and safe to remove 👍 @fnxpt Is it possible to add instructions on what you did for the auto-translation part? Thinking in terms of contributors here. If they add new fields and CI starts failing due to incomplete translations, we'll need instructions on what to do to resolve. Separately, I know you said the language can be switched in the browser. Would there be any point in adding an application-level toggle as well? Say my browser is set to German, but I actually prefer to use my applications in english. |
ok, I had a better look on how we can improve the automation part, the plugin I suggested for vscode supports this |
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fnxpt, great enhancement!
@fnxpt - nice addition. We might need to update this section in the projects README.md 😄 |
Description
strings added missing:
strings removed unused:
Addressed Issue
Additional Details
Checklist