fix: require VIEW_PORTFOLIO permission for BOM download #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Schuh <github@eneticum.de>
|
@nscuro is this going to happen anytime soon? |
nscuro
added a commit
to nscuro/dependency-track-frontend
that referenced
this pull request
Apr 14, 2024
Fixes DependencyTrack/dependency-track#2053 Closes DependencyTrack#465 Co-authored-by: Robert Schuh <github@eneticum.de> Signed-off-by: nscuro <nscuro@protonmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the frontend requires a different permission to download a bom than the backend.
https://github.com/DependencyTrack/dependency-track/blob/4.7.1/src/main/java/org/dependencytrack/resources/v1/BomResource.java#L95
Require the VIEW_PORTFOLIE instead of PORTFOLIO_MANAGEMENT permission in the frontend for bom download
Addressed Issue
#2053
Checklist