Show component properties to users with VIEW_PORTFOLIO permission #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the button to `Properties` in the component details modal was not shown to users not having the `PORTFOLIO_EDIT` permission. With this change Users with the `VIEW_PORTFOLIO` permission can see the properties. Signed-off-by: Maximilian Wirtz <maximilian.wirtz@checkmk.com>
nscuro
added
defect
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change Users with the
VIEW_PORTFOLIOpermission can see the component properties.Addressed Issue
Previously the button to
Propertiesin the component details modal was not shown to users not having thePORTFOLIO_EDITpermission.AFAIK there is no issue for this.
Additional Details
Details view after Change only with
VIEW_PORTFOLIOpermission:Property view only with
VIEW_PORTFOLIOpermission:Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordinglyIMHO this behavior is not mentioned in the docs