Skip to content

Commit

Permalink
Merge pull request #580 from nscuro/spdx-expression-improvements
Browse files Browse the repository at this point in the history
Fix license expression input fields
  • Loading branch information
nscuro authored Aug 22, 2023
2 parents 5e69238 + 787a745 commit 16735ff
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/views/portfolio/projects/ComponentDetailsModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@
author: this.component.author,
description: this.component.description,
license: this.selectedLicense,
licenseExpression: this.component.licenseExpression,
licenseUrl: this.component.licenseUrl,
filename: this.component.filename,
classifier: this.component.classifier,
Expand Down Expand Up @@ -258,6 +259,8 @@
retrieveLicenses: function() {
let url = `${this.$api.BASE_URL}/${this.$api.URL_LICENSE_CONCISE}`;
this.axios.get(url).then((response) => {
// Allow for license to be un-selected.
this.selectableLicenses.push({value: '', text: ''});
for (let i = 0; i < response.data.length; i++) {
let license = response.data[i];
this.selectableLicenses.push({value: license.licenseId, text: license.name, uuid: license.uuid});
Expand Down
8 changes: 8 additions & 0 deletions src/views/portfolio/projects/ProjectAddComponentModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
<b-input-group-form-select id="component-license-input" required="false"
v-model="selectedLicense" :options="selectableLicenses"
:label="$t('message.license')" :tooltip="$t('message.component_spdx_license_desc')" />
<b-input-group-form-input id="component-license-expression" input-group-size="mb-3" type="text" v-model="component.licenseExpression"
required="false" :label="$t('message.license_expression')" :tooltip="$t('message.component_license_expression_desc')" />
<b-input-group-form-input id="component-license-url-input" input-group-size="mb-3" type="text" v-model="component.licenseUrl"
required="false" :label="$t('message.license_url')" :tooltip="$t('message.component_license_url_desc')" />
<b-form-group
id="component-copyright-form-group"
:label="this.$t('message.copyright')"
Expand Down Expand Up @@ -138,6 +142,7 @@
group: this.component.group,
description: this.component.description,
license: this.selectedLicense,
licenseExpression: this.component.licenseExpression,
licenseUrl: this.component.licenseUrl,
filename: this.component.filename,
classifier: this.component.classifier,
Expand Down Expand Up @@ -167,6 +172,7 @@
group: null,
description: null,
license: null,
licenseExpression: null,
licenseUrl:null,
filename: null,
classifier: null,
Expand All @@ -186,6 +192,8 @@
retrieveLicenses: function() {
let url = `${this.$api.BASE_URL}/${this.$api.URL_LICENSE_CONCISE}`;
this.axios.get(url).then((response) => {
// Allow for license to be un-selected.
this.selectableLicenses.push({value: '', text: ''});
for (let i = 0; i < response.data.length; i++) {
let license = response.data[i];
this.selectableLicenses.push({value: license.licenseId, text: license.name});
Expand Down

0 comments on commit 16735ff

Please sign in to comment.