Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TVL for Elixir #12485

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix TVL for Elixir #12485

merged 1 commit into from
Dec 1, 2024

Conversation

cairoeth
Copy link
Contributor

Fixes TVL calculation by counting deUSD and stETH + ETH commits.

@llamatester
Copy link

The adapter at projects/elixir exports TVL:

ethereum                  283.90 M
ethereum-pool2            55.75 M
pool2                     55.75 M
arbitrum                  5.99 M

total                    289.89 M 

@g1nt0ki
Copy link
Member

g1nt0ki commented Nov 28, 2024

hi @cairoeth what is backing the deUSD? we got complaints that we were doublecounting by including the value of both the commits & deUSD supply

@g1nt0ki g1nt0ki self-assigned this Nov 28, 2024
@cairoeth
Copy link
Contributor Author

@g1nt0ki it's backed by USD, like USDT, DAI, etc. -- as you can see in the diff, i removed the backing address and those tokens so there's no double counting

@g1nt0ki
Copy link
Member

g1nt0ki commented Nov 28, 2024

hmm, but deUSD supply is 169m but address you removed has only 53M worth of USDS

@cairoeth
Copy link
Contributor Author

hmm, but deUSD supply is 169m but address you removed has only 53M worth of USDS

the rest of the backings are distributed across centralized exchange venues to run the basis trade, as noted here.

@0xpeluche
Copy link
Contributor

Hello @cairoeth , I'm trying to review the adapter to correct the calculations on my end as well. There are some confusing aspects of the mechanisms for minting deUSD. Were the ETH in the COMMITS_VAULT purchased with users' stablecoins? This would mean that when 100k deUSD is minted, 50k is shorted on Coinbase, and 50k is used to buy stETH and deposited in the commits vaults. If that's the case, we can't count both the deUSD and the stETH at the same time

@cairoeth
Copy link
Contributor Author

@0xpeluche stETH tokens have been committed to mint deUSD in December, but they haven't been used yet meaning they are not part of the deUSD supply so there's no double counting. Even once they are used to mint, deUSD supply would increase and stETH balance would decrease so still no double counting.

@g1nt0ki
Copy link
Member

g1nt0ki commented Nov 30, 2024

@cairoeth thanks for the clarification

@realdealshaman realdealshaman merged commit b159d16 into DefiLlama:main Dec 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants