API: Convert get_filterset calls to get_queryset

[Maffooch]

Correcting copy/paste errors from #10503

The get_fitlerset method uses the request object to perform database filtering based upon the kwargs supplied in the request body. The intended behavior is to use the get_queryset method to override the functionality that fetches all objects from the database, with filtering being performed afterwards.

[dryrunsecurity]

DryRun Security Summary

The pull request refactors the filter_queryset method to get_queryset in various ViewSets in the dojo/api_v2/views.py file, a common pattern in Django REST Framework that is likely to improve the application's performance and maintainability, while the access control and authorization mechanisms remain in place to ensure users can only access the data they are authorized to view.

Expand for full summary

Summary:

The code changes in this pull request appear to be a refactoring of the filter_queryset method to get_queryset in various ViewSets in the dojo/api_v2/views.py file. This change is a common pattern in Django REST Framework (DRF) and is likely to improve the overall performance and maintainability of the application.

From an application security perspective, the changes do not appear to introduce any significant security risks. The access control and authorization mechanisms (e.g., permission_classes) remain in place, ensuring that users can only access the data they are authorized to view. However, it's important to continue monitoring the application's security posture and address any potential vulnerabilities, such as ensuring proper input sanitization and validation, verifying the access control and authorization mechanisms, and monitoring for any unusual activity or security incidents.

Files Changed:

• dojo/api_v2/views.py: This file has been updated to replace the filter_queryset method with get_queryset in various ViewSets. This change is a common pattern in DRF and is likely to improve the overall performance and maintainability of the application. The access control and authorization mechanisms remain in place, ensuring that users can only access the data they are authorized to view.

Code Analysis

We ran 7 analyzers against 1 file and 1 analyzer had findings. 6 analyzers had no findings.

Analyzer	Findings
Authn/Authz Analyzer	19 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud