Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry network failures when fetching data from FA #122

Merged
merged 1 commit into from
Mar 15, 2024

Retry network failures up to 5 times over up to 3 seconds when trying…

6394ec8
Select commit
Loading
Failed to load commit list.
Merged

Retry network failures when fetching data from FA #122

Retry network failures up to 5 times over up to 3 seconds when trying…
6394ec8
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Rubocop succeeded Mar 15, 2024 in 2s

2 new alerts

New alerts in code changed by this pull request

  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 1336 in lib/faexport/scraper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Check for conditionals that can be replaced with guard clauses. Note

Style/GuardClause: Use a guard clause (raise unless retry_attempts < 5) instead of wrapping the code inside a conditional expression.

Check notice on line 1349 in lib/faexport/scraper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Check for conditionals that can be replaced with guard clauses. Note

Style/GuardClause: Use a guard clause (raise unless retry_attempts < 5) instead of wrapping the code inside a conditional expression.