Reworked quern processing for food so it handles weight in recipe. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables recipe that consume part of the food stack instead of always using all the weight. It also enables other ratio of production instead of it always being 1-to-1 conversion. As a side effect, quern processing now also doesn't carry decay over to result, instead reducing result weight (much like salad/sandwich don't have decay from their ingredients).
|
I've just started testing this, but I've already noticed something that needs to be fixed. Food that has 0 decay that is ground results in flour that has the -24.0 decay of something that is freshly harvested. It needs to be 0. It also appears that you aren't accounting for the food in the output slot also having decay on it. |
|
Allright, I'll take a look at it. Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables recipe that consume part of the food stack instead of always using all the weight. It also enables other ratio of production instead of it always being 1-to-1 conversion (for addon support, if anyone wishes so).
As a side effect, quern processing now also doesn't carry decay over to result, instead reducing result weight when not enough food is available (much like salad/sandwich don't have decay from their ingredients).
At the same time, I'd like to suggest changing the recipe for flour to be only 10oz at a time. Like this, 160oz of grain take 16 turn to fully grind in flour, much like 16 graphite (or any other stack of 16 rocks). Grinding 160oz of grain to 160oz of flour seems too easy to me. This change is not included in the request, but I could easily make it so.