feat(yarn): add support for Yarn 4 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
commented
Jun 20, 2024
Comment on lines
-1
to
-9
| plugins: | ||
| - path: .yarn/plugins/@yarnpkg/plugin-typescript.cjs | ||
| spec: "@yarnpkg/plugin-typescript" | ||
| - path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs | ||
| spec: "@yarnpkg/plugin-workspace-tools" | ||
| - path: .yarn/plugins/@yarnpkg/plugin-constraints.cjs | ||
| spec: "@yarnpkg/plugin-constraints" | ||
| - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs | ||
| spec: "@yarnpkg/plugin-interactive-tools" |
There was a problem hiding this comment.
All these plugins are now part of yarn itself.
Comment on lines
+24
to
+28
| all = Option.Boolean('-A,--all', false); | ||
|
|
||
| recursive = Option.Boolean('-R,--recursive', false); | ||
|
|
||
| worktree = Option.Boolean('-W,--worktree', false); |
There was a problem hiding this comment.
At least one of these is now required for yarn workspaces foreach
Comment on lines
-119
to
+115
| const manifestDir = ppath.join(cwd, toFilename('manifests')); | ||
| const packDir = ppath.join(cwd, toFilename('packs')); | ||
| const manifestDir = ppath.join(cwd, 'manifests'); | ||
| const packDir = ppath.join(cwd, 'packs'); |
There was a problem hiding this comment.
toFilename was removed but not mentioned in the changelog. The recommendation is to cast to Filename instead where needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some of the recommended migrations from the Yarn 4 release notes, plus a few code changes I had to figure out.
I tested only the
changedplugin, so unfortunately I can't guarantee that the others are working as-is.